Refactor Time #56
Merged
Refactor Time #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngusGMorrison
commented
Feb 9, 2024
helgee
requested changes
Feb 9, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
==========================================
- Coverage 97.85% 97.82% -0.04%
==========================================
Files 42 41 -1
Lines 17376 17398 +22
==========================================
+ Hits 17003 17019 +16
- Misses 373 379 +6 ☔ View full report in Codecov by Sentry. |
helgee
approved these changes
Feb 10, 2024
| } | ||
|
|
||
| #[test] | ||
| fn test_unscaled_time_centuries_since_j2000() { |
There was a problem hiding this comment.
I would recommend the rstest crate for parametrising test.
There was a problem hiding this comment.
I was going to ask about whether we wanted to standardise. I'll update them to rstest in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #55.
Refactors
Timeby making it generic over implementations of theTimeScalemarker trait.